Merged
Conversation
Signed-off-by: Stanislav Láznička <slznika@microsoft.com>
Signed-off-by: Stanislav Láznička <slznika@microsoft.com>
ibihim
reviewed
Mar 23, 2026
|
|
||
| env: | ||
| QUAY_PATH: quay.io/brancz/kube-rbac-proxy | ||
| go-version: 1.25.8 |
Collaborator
There was a problem hiding this comment.
wondering if we need to document this, because people don't bump this, but go.mod.
ibihim
reviewed
Mar 23, 2026
| password: ${{ secrets.QUAY_PASSWORD }} | ||
|
|
||
| - name: Build images and push | ||
| run: ./scripts/publish.sh |
Collaborator
There was a problem hiding this comment.
exit 1 on non tags. pretty please
Signed-off-by: Stanislav Láznička <slznika@microsoft.com>
Collaborator
|
Lets give it a try :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We seem to be publishing a lot in the Quay repo.
This PR reduces the amount of publishing to the repo only to v*-tags pushes.
The job no longer requires passing of all the previous jobs so it's important for PR CI to be run on the version that's getting tagged - but we already do that today.
Also explicitly scope down GH action permissions.
Might help with #400 if we don't push that many new tags, though not sure if this will exactly counter the Quay behavior described in the issue.